Daniel van Vugt [Sun, 18 Mar 2018 16:56:36 +0000 (12:56 -0400)]
backends/x11: Support input-synaptics, if present.
Add support for configuring the Xorg synaptics touchpad driver.
Turns out it's very simple to support both libinput and synaptics
simultaneously, both under the heading of XI2.
Bug-Ubuntu: https://launchpad.net/bugs/1686081
Forwarded: https://gitlab.gnome.org/GNOME/mutter/merge_requests/37
Applied-upstream: no, rejected as not long-term sustainable
Last-Update: 2018-03-16
Gbp-Pq: Topic debian
Gbp-Pq: Name synaptics-support.patch
Florian Müllner [Thu, 20 Oct 2016 16:00:04 +0000 (18:00 +0200)]
gtk-shell: Work around non-working startup notifications
GNOME Shell relies on the MetaScreen::startup-sequence-changed signal,
which is tied to (lib)startup-notification and therefore X11. As a result,
when we remove the startup sequence of a wayland client, GNOME Shell will
not be notified about this until startup-notification's timeout is hit.
As a temporary stop-gap, go through XWayland even for wayland clients,
so that the signal is emitted when expected.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=768531
Applied-upstream: no
Gbp-Pq: Name bgo768531_workaround-startup-notifications.patch
Daniel van Vugt [Fri, 16 Feb 2018 08:50:59 +0000 (02:50 -0600)]
clutter: Smooth out master clock to smooth visuals
Clutter's master clock was jittery because it included errors in cur_tick
such as dispatch delays due to other sources. Dispatch could also occur up
to 1ms early since GSource can only be timed to the millisecond. All of this
could impact the visual smoothness of animations as they are displayed on
the steady interval of the monitor, but spacially moving in less regular
steps derived from the dispatch times.
The simple fix is to ignore any jitter in dispatch timing. Try a little
bit harder to use a precise interval that will better match the display
hardware, and smoother visuals will follow.
Daniel van Vugt [Sun, 18 Mar 2018 16:56:36 +0000 (12:56 -0400)]
backends/x11: Support input-synaptics, if present.
Add support for configuring the Xorg synaptics touchpad driver.
Turns out it's very simple to support both libinput and synaptics
simultaneously, both under the heading of XI2.
Bug-Ubuntu: https://launchpad.net/bugs/1686081
Forwarded: https://gitlab.gnome.org/GNOME/mutter/merge_requests/37
Applied-upstream: no, rejected as not long-term sustainable
Last-Update: 2018-03-16
Gbp-Pq: Topic debian
Gbp-Pq: Name synaptics-support.patch
Florian Müllner [Thu, 20 Oct 2016 16:00:04 +0000 (18:00 +0200)]
gtk-shell: Work around non-working startup notifications
GNOME Shell relies on the MetaScreen::startup-sequence-changed signal,
which is tied to (lib)startup-notification and therefore X11. As a result,
when we remove the startup sequence of a wayland client, GNOME Shell will
not be notified about this until startup-notification's timeout is hit.
As a temporary stop-gap, go through XWayland even for wayland clients,
so that the signal is emitted when expected.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=768531
Applied-upstream: no
Gbp-Pq: Name bgo768531_workaround-startup-notifications.patch
Daniel van Vugt [Fri, 16 Feb 2018 08:50:59 +0000 (02:50 -0600)]
clutter: Smooth out master clock to smooth visuals
Clutter's master clock was jittery because it included errors in cur_tick
such as dispatch delays due to other sources. Dispatch could also occur up
to 1ms early since GSource can only be timed to the millisecond. All of this
could impact the visual smoothness of animations as they are displayed on
the steady interval of the monitor, but spacially moving in less regular
steps derived from the dispatch times.
The simple fix is to ignore any jitter in dispatch timing. Try a little
bit harder to use a precise interval that will better match the display
hardware, and smoother visuals will follow.
Jonas Ådahl [Tue, 31 Jul 2018 11:18:51 +0000 (13:18 +0200)]
monitor: Use current monitor mode to check whether active
For historical reasons meta_monitor_is_active() checked whether it is
active by checking whether the main output have a CRTC assigned and
whether that CRTC has a current mode. At a later point, the MetaMonitor
got its own mode abstraction (MetaMonitorMode), but
meta_monitor_is_active() was never updated to use this.
An issue with checking the main output's CRTC state is that, if there is
some CRTC mode combination that for some reason isn't properly detected
by the MetaMonitorMode abstraction (e.g. some tiling configuration not
yet handled), meta_monitor_is_active() would return TRUE, even though no
(abstracted) mode was set. This would cause confusion here and there,
leading to NULL pointer dereferences due to the assumption that if a
monitor is active, it has an active mode.
Instead, change meta_monitor_is_active() to directly check the current
monitor mode, and log a warning if the main output still happen to have
a CRTC with a mode assigned to it. This way, when an not undrestood CRTC
mode combination is encountered, instead of dereferencing NULL pointers,
simply assume the monitor is not active, which means that it will not be
managed or rendered by mutter at all.
Florian Müllner [Fri, 25 May 2018 19:24:17 +0000 (21:24 +0200)]
window: Explicitly exclude unmanaging window from focus again
Since commit b3b9d9e16 we no longer have to pass the unmanaging window
to make sure we don't try to focus it again, however the parameter also
influences the focus policy by giving ancestors preference over the normal
stack order.
Florian Müllner [Fri, 25 May 2018 18:18:23 +0000 (18:18 +0000)]
window: Don't refuse to move focus to the grab window
We refuse to move focus while a grab operation is in place. While this
generally makes sense, there's no reason why the window that owns the
grab shouldn't be given the regular input focus as well - we pretty
much assume that the grab window is also the focus window anyway.
In fact there's a strong reason for allowing the focus change here:
If the grab window isn't the focus window, it probably has a modal
transient that is focused instead, and a likely reason for the focus
request is that the transient is being unmanaged and we must move
the focus elsewhere.
Olivier Fourdan [Mon, 18 Jun 2018 10:39:11 +0000 (12:39 +0200)]
window/wayland: Always update monitor for non-user ops
meta_window_wayland_update_main_monitor() would skip the monitor update
if the difference in scale between the old and the new monitor would
cause another monitor change.
While this is suitable when the monitor change results from a user
interactively moving the surface between monitors of different scales,
this can leave dangling pointers to freed monitors when this is
triggered by a change of monitor configuration.
Make sure we update the monitor unconditionally if not from a user
operation.
Andrea Azzarone [Mon, 16 Jul 2018 16:09:40 +0000 (18:09 +0200)]
monitor-manager: Filter out low screen resolutions
Avoid exporting through org.gnome.Mutter.DisplayConfig.GetCurrentState
excessively-low screen resolutions setting both a minimum width and a minimum
height. GetCurrentState is e.g. used by Gnome Control Center to build a list of
selectable resolutions.
If drmModeSetCrtc() is called with no fb, mode or connectors for some
CRTC it may still fail, and we should handle that gracefully instead of
assuming it failed to set a non-disabled state.
gpu-kms: Don't crash if drmModeGetResources returns NULL
DRM drivers can be opened by meta_launcher_open_restricted() even if they don't
implement modesetting. However, drmModeGetResources() will return NULL.
Check whether that happened in meta_gpu_kms_new() and return with an error
instead of crashing.
Simon McVittie [Tue, 31 Jul 2018 14:35:03 +0000 (15:35 +0100)]
mutter (3.28.3-2) unstable; urgency=medium
* Team upload
[ Iain Lane ]
* debian/gbp.conf: Set the upstream branch to upstream/3.28.x, since we've
branched for experimental now.
[ Marco Trevisan (Treviño) ]
* d/p/native-gpu-Handle-drmModeSetCrtc-failing-gracefully.patch:
- Avoid crashing when warning about wrongly set crtc mode
(LP: #1754949)
* d/p/gpu-kms-Don-t-crash-if-drmModeGetResources-returns-N.patch:
- Don't crash if drmModeGetResources returns NULL (LP: #1767956)
* d/p/window-wayland-Always-update-monitor-for-non-user-ops.patch:
- Always update monitor in wayland, avoiding crash (LP: #1784398)
* d/p/monitor-manager-Filter-out-low-screen-resolutions.patch:
- Don't return screen resolutions that can't be applied (LP: #1772831)
* d/p/window-Don-t-refuse-to-move-focus-to-the-grab-window.patch,
d/p/window-Explicitly-exclude-unmanaging-window-from-focus-ag.patch:
- Don't crash if a modal dialog closes while being dragged
(LP: #1422253)
* d/p/monitor-Use-current-monitor-mode-to-check-whether-active.patch:
- Don't try to use an invalid monitor mode to figure out scaling
(LP: #1723615)
[ Simon McVittie ]
* Sort patch series in upstream order, with patches applied upstream
first
* d/copyright: Remove obsolete FSF postal addresses
* Standards-Version: 4.1.5 (no changes required)
* Set Rules-Requires-Root to no
* Update symbols file
Daniel van Vugt [Sun, 18 Mar 2018 16:56:36 +0000 (12:56 -0400)]
backends/x11: Support input-synaptics, if present.
Add support for configuring the Xorg synaptics touchpad driver.
Turns out it's very simple to support both libinput and synaptics
simultaneously, both under the heading of XI2.
Bug-Ubuntu: https://launchpad.net/bugs/1686081
Forwarded: https://gitlab.gnome.org/GNOME/mutter/merge_requests/37
Applied-upstream: no, rejected as not long-term sustainable
Last-Update: 2018-03-16
Gbp-Pq: Topic debian
Gbp-Pq: Name synaptics-support.patch
Florian Müllner [Thu, 20 Oct 2016 16:00:04 +0000 (18:00 +0200)]
gtk-shell: Work around non-working startup notifications
GNOME Shell relies on the MetaScreen::startup-sequence-changed signal,
which is tied to (lib)startup-notification and therefore X11. As a result,
when we remove the startup sequence of a wayland client, GNOME Shell will
not be notified about this until startup-notification's timeout is hit.
As a temporary stop-gap, go through XWayland even for wayland clients,
so that the signal is emitted when expected.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=768531
Applied-upstream: no
Gbp-Pq: Name bgo768531_workaround-startup-notifications.patch
Daniel van Vugt [Fri, 16 Feb 2018 08:50:59 +0000 (02:50 -0600)]
clutter: Smooth out master clock to smooth visuals
Clutter's master clock was jittery because it included errors in cur_tick
such as dispatch delays due to other sources. Dispatch could also occur up
to 1ms early since GSource can only be timed to the millisecond. All of this
could impact the visual smoothness of animations as they are displayed on
the steady interval of the monitor, but spacially moving in less regular
steps derived from the dispatch times.
The simple fix is to ignore any jitter in dispatch timing. Try a little
bit harder to use a precise interval that will better match the display
hardware, and smoother visuals will follow.
Daniel van Vugt [Sun, 18 Mar 2018 16:56:36 +0000 (12:56 -0400)]
backends/x11: Support input-synaptics, if present.
Add support for configuring the Xorg synaptics touchpad driver.
Turns out it's very simple to support both libinput and synaptics
simultaneously, both under the heading of XI2.
Bug-Ubuntu: https://launchpad.net/bugs/1686081
Forwarded: https://gitlab.gnome.org/GNOME/mutter/merge_requests/37
Applied-upstream: no, rejected as not long-term sustainable
Last-Update: 2018-03-16
Gbp-Pq: Topic debian
Gbp-Pq: Name synaptics-support.patch
Florian Müllner [Thu, 20 Oct 2016 16:00:04 +0000 (18:00 +0200)]
gtk-shell: Work around non-working startup notifications
GNOME Shell relies on the MetaScreen::startup-sequence-changed signal,
which is tied to (lib)startup-notification and therefore X11. As a result,
when we remove the startup sequence of a wayland client, GNOME Shell will
not be notified about this until startup-notification's timeout is hit.
As a temporary stop-gap, go through XWayland even for wayland clients,
so that the signal is emitted when expected.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=768531
Applied-upstream: no
Gbp-Pq: Name bgo768531_workaround-startup-notifications.patch
Daniel van Vugt [Fri, 16 Feb 2018 08:50:59 +0000 (02:50 -0600)]
clutter: Smooth out master clock to smooth visuals
Clutter's master clock was jittery because it included errors in cur_tick
such as dispatch delays due to other sources. Dispatch could also occur up
to 1ms early since GSource can only be timed to the millisecond. All of this
could impact the visual smoothness of animations as they are displayed on
the steady interval of the monitor, but spacially moving in less regular
steps derived from the dispatch times.
The simple fix is to ignore any jitter in dispatch timing. Try a little
bit harder to use a precise interval that will better match the display
hardware, and smoother visuals will follow.
device-manager-evdev: Add main seat to seats by default
Treat the main seat as other seats, so we don't have to handle it differently
in specific places. This was already the case before when a real device
was plugged before the startup, but not applied when hotplugging a device.
device-manager-evdev: Set and unset the stage for the main seat too
When no input devices are available on startup the device manager might be fast
enough to be constructed so that no default stage is set yet, and thus when
main seat virtual devices are created they won't have a proper stage set.
If then we plug a real device, the events that an input manager could generate
won't be associated to any stage and thus won't be processed.
We need then ensure that when we update the stage for the device manager we
(un)associate it also to the main seat devices.
clutter-device-evdev: Get devices from main seat if no real seat is set
In devices such as ARM boards there could be no input devices connected on
startup, leading to a crash when we try to process artificial events that
could be queued (as gnome-shell does when syncing pointer).
Those events still should refer to a device and, in case we don't have one
provided by libinput we should still return the core devices defined in the
main seat.
Compositor effects change the actor size and position, which can lead to
inconsistent output enter/leave notifications, leaving clients' surfaces
without any output set.
Update output enter/leave notifications after all compositor effects are
completed so that we give clients accurate output location.
When using plugins, the effects will affect the MetaWindowActor size
and position.
Add a new signal "effects-completed" wired to the corresponding
MetaWindowActor which is emitted when all effects are completed so that
derived objects can be notified when all effects are completed and use
the actual size and position.
After 20176d03, the Wayland backend only synchronizes with the
compositor after a geometry was set, and it was different from
the current geometry.
That commit was mistakenly comparing the geometry before chaining
up, which would yield a false negative on the case where the
client didn't call set_geometry() before commit().
Fix that by caching the old geometry locally, chain up (and thus
apply the new geometry rectangle), then comparing the old and
current geometry rectangles.
Carlos Garnacho [Sun, 15 Apr 2018 14:26:32 +0000 (16:26 +0200)]
frames: Handle touch events
This is just done on wayland as it'll break horribly on X11, we let
this happen through pointer emulated events in XISelectEvents evmask
instead.
Some things had to be made slightly more generic to accomodate touch
events. The MetaFrames shall lock onto a single touch at a time, we
don't allow crazy stuff like multi-window drag nor multi-edge resizes.
Mark CAPS lock as a modifier (as it should) so that when using XKB
options to change the default behaviour of CAPS lock, the new assigned
key can by used as a sticky key as well.
Olivier Fourdan [Fri, 23 Mar 2018 12:05:12 +0000 (13:05 +0100)]
wayland: Use cursor position in logical monitor
When using two monitors size by side with different scales, once the
cursor moves from one output to another one, its size changes based on
the scale of the given output.
Changing the size of the cursor can cause the cursor area to change
output again if the hotspot is not exactly at the top left corner of the
area, causing the texture of the cursor to change, which will trigger
another output change, so on and so forth causing continuous surface
enter/leave event which flood the clients and eventually kill them.
Change the logic to use only the actual cursor position to determine if
its on the given logical monitor, so that it remains immune to scale
changes induced by output scale differences.
Simon McVittie [Sun, 8 Jul 2018 10:32:56 +0000 (11:32 +0100)]
mutter (3.28.2-3) unstable; urgency=medium
* Team upload
* d/p/backends-Move-MetaOutput-crtc-field-into-private-struct.patch,
d/p/backends-Add-logical-monitor-monitor-output-crtc-ref-chai.patch:
Mark as applied upstream
* d/p/backends-Move-MetaOutput-crtc-field-into-private-struct.patch:
Update to the version that was applied upstream
* d/p/frames-Handle-touch-events.patch,
d/p/frames-Make-1st-button-motion-handlers-take-generic-event.patch,
d/p/frames-Allow-for-unknown-mouse-buttons.patch:
Reinstate patches dropped in previous upload, along with the
upstream fix for #899181
* d/p/wayland-Compare-geometries-after-chaining-up.patch,
d/p/window-actor-add-new-signal-effects-completed.patch,
d/p/wayland-update-enter-leave-output-after-effects.patch,
d/p/frames-Allow-for-unknown-mouse-buttons.patch,
d/p/wayland-Don-t-reset-input-focus-on-text-commit.patch,
d/p/clutter-seat-evdev-Add-function-to-get-device-by-id.patch,
d/p/clutter-device-evdev-Get-devices-from-main-seat-if-no-rea.patch,
d/p/device-manager-evdev-Set-and-unset-the-stage-for-the-main.patch,
d/p/device-manager-evdev-Free-the-main-seat-on-finalize.patch,
d/p/device-manager-evdev-Add-main-seat-to-seats-by-default.patch,
d/p/renderer-native-Don-t-crash-if-the-FB-surface-can-t-be-lo.patch:
Update to upstream gnome-3-28 branch
* Add a symbols file for libmutter-2-0
* d/copyright: Copy many licenses and copyright holders into this file,
multiplying its length by 5 (Closes: #891156)
Daniel van Vugt [Sun, 18 Mar 2018 16:56:36 +0000 (12:56 -0400)]
backends/x11: Support input-synaptics, if present.
Add support for configuring the Xorg synaptics touchpad driver.
Turns out it's very simple to support both libinput and synaptics
simultaneously, both under the heading of XI2.
Bug-Ubuntu: https://launchpad.net/bugs/1686081
Forwarded: https://gitlab.gnome.org/GNOME/mutter/merge_requests/37
Applied-upstream: no, rejected as not long-term sustainable
Last-Update: 2018-03-16
Gbp-Pq: Topic debian
Gbp-Pq: Name synaptics-support.patch
Florian Müllner [Thu, 20 Oct 2016 16:00:04 +0000 (18:00 +0200)]
gtk-shell: Work around non-working startup notifications
GNOME Shell relies on the MetaScreen::startup-sequence-changed signal,
which is tied to (lib)startup-notification and therefore X11. As a result,
when we remove the startup sequence of a wayland client, GNOME Shell will
not be notified about this until startup-notification's timeout is hit.
As a temporary stop-gap, go through XWayland even for wayland clients,
so that the signal is emitted when expected.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=768531
Applied-upstream: no
Gbp-Pq: Name bgo768531_workaround-startup-notifications.patch
Clutter's master clock was jittery because it included errors in cur_tick
such as dispatch delays due to other sources. Dispatch could also occur up
to 1ms early since GSource can only be timed to the millisecond. All of this
could impact the visual smoothness of animations as they are displayed on
the steady interval of the monitor, but spacially moving in less regular
steps derived from the dispatch times.
The simple fix is to ignore any jitter in dispatch timing. Try a little
bit harder to use a precise interval that will better match the display
hardware, and smoother visuals will follow.
https://gitlab.gnome.org/GNOME/mutter/issues/25
Gbp-Pq: Name clutter-Smooth-out-master-clock-to-smooth-visuals.patch
Mark CAPS lock as a modifier (as it should) so that when using XKB
options to change the default behaviour of CAPS lock, the new assigned
key can by used as a sticky key as well.
Olivier Fourdan [Fri, 23 Mar 2018 12:05:12 +0000 (13:05 +0100)]
wayland: Use cursor position in logical monitor
When using two monitors size by side with different scales, once the
cursor moves from one output to another one, its size changes based on
the scale of the given output.
Changing the size of the cursor can cause the cursor area to change
output again if the hotspot is not exactly at the top left corner of the
area, causing the texture of the cursor to change, which will trigger
another output change, so on and so forth causing continuous surface
enter/leave event which flood the clients and eventually kill them.
Change the logic to use only the actual cursor position to determine if
its on the given logical monitor, so that it remains immune to scale
changes induced by output scale differences.
Simon McVittie [Sun, 20 May 2018 14:21:35 +0000 (15:21 +0100)]
mutter (3.28.2-2) unstable; urgency=medium
* Team upload
* d/p/frames-Handle-touch-events.patch,
d/p/frames-Make-1st-button-motion-handlers-take-generic-event.patch:
Drop cherry-picked patches that caused a regression (Closes: #899181)
Ray Strode [Thu, 12 Apr 2018 18:06:01 +0000 (13:06 -0500)]
xwayland: Don't abort if Xwayland crashes
Right now if Xwayland crashes, we crash, too.
On some level that makes sense, since we're supposed to control the
lifecycle of Xwayland, and by it crashing we've lost that control.
But practically speaking, the knock-on crash adds noise to the logs,
bug trackers, and retrace servers that only makes debugging harder.
And the crash isn't something mutter can "fix", since it's
ultimately from a bug in Xwayland anyway.
This commit makes mutter exit instead of crash if Xwayland goes away
unexpectedly.
Ray Strode [Thu, 12 Apr 2018 18:03:03 +0000 (13:03 -0500)]
xwayland: use g_autoptr for GError in xserver_died
Right now we explicitly g_clear_error any error we find, but that
makes it tricky to return early from the function, which a
subsequent commit will want to to do.
This commit switches GError to use g_autoptr so the error clearing
happens automatically.
projects / mutter.git / log